Mercurial > hgrepos > FreeBSD > ports > sysutils > local-bsdtools

changeset 535:33b55434d039

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
common.subr: handle some shellcheck warnings
author Franz Glasner <fzglas.hg@dom66.de>
date Mon, 09 Sep 2024 13:31:58 +0200
parents 46c4798b9b31
children b0148ccbc459
files share/local-bsdtools/common.subr
diffstat 1 files changed, 10 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/share/local-bsdtools/common.subr	Mon Sep 09 12:33:00 2024 +0200
+++ b/share/local-bsdtools/common.subr	Mon Sep 09 13:31:58 2024 +0200
@@ -1,3 +1,4 @@
+#!/bin/sh
 # -*- mode: shell-script; indent-tabs-mode: nil; -*-
 #:
 #: :Author:    Franz Glasner
@@ -11,6 +12,9 @@
 #:
 
 
+# shellcheck disable=3003,3043
+
+
 #: The path to the external jq executable (JSON parser)
 JQ="/usr/local/bin/jq"
 
@@ -31,13 +35,13 @@
     local _ec
 
     if [ $# -ge 1 ]; then
-        _ec=$1
+        _ec="$1"
         shift
     else
         _ec=1
     fi
     printf "%s: ERROR: %s\\n" "$0" "$*"
-    exit ${_ec}
+    exit "${_ec}"
 }
 
 
@@ -89,8 +93,8 @@
 checkyesno() {
     local _value
 
-    eval _value=\${${1}}
-    case $_value in
+    eval _value=\$\{"${1}"\}
+    case "${_value}" in
         # "yes", "true", "on", or "1"
         [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1)
             return 0
@@ -122,8 +126,8 @@
 checkyes() {
     local _value
 
-    eval _value=\${${1}}
-    case $_value in
+    eval _value=\$\{"${1}"\}
+    case "${_value}" in
         # "yes", "true", "on", or "1"
         [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1)
             return 0