# HG changeset patch
# User Franz Glasner <fzglas.hg@dom66.de>
# Date 1725881518 -7200
# Node ID 33b55434d0394ac30c4c3e1f1d910277674af549
# Parent  46c4798b9b31ae8b4cdad3f598815a5a1b347135
common.subr: handle some shellcheck warnings

diff -r 46c4798b9b31 -r 33b55434d039 share/local-bsdtools/common.subr
--- a/share/local-bsdtools/common.subr	Mon Sep 09 12:33:00 2024 +0200
+++ b/share/local-bsdtools/common.subr	Mon Sep 09 13:31:58 2024 +0200
@@ -1,3 +1,4 @@
+#!/bin/sh
 # -*- mode: shell-script; indent-tabs-mode: nil; -*-
 #:
 #: :Author:    Franz Glasner
@@ -11,6 +12,9 @@
 #:
 
 
+# shellcheck disable=3003,3043
+
+
 #: The path to the external jq executable (JSON parser)
 JQ="/usr/local/bin/jq"
 
@@ -31,13 +35,13 @@
     local _ec
 
     if [ $# -ge 1 ]; then
-        _ec=$1
+        _ec="$1"
         shift
     else
         _ec=1
     fi
     printf "%s: ERROR: %s\\n" "$0" "$*"
-    exit ${_ec}
+    exit "${_ec}"
 }
 
 
@@ -89,8 +93,8 @@
 checkyesno() {
     local _value
 
-    eval _value=\${${1}}
-    case $_value in
+    eval _value=\$\{"${1}"\}
+    case "${_value}" in
         # "yes", "true", "on", or "1"
         [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1)
             return 0
@@ -122,8 +126,8 @@
 checkyes() {
     local _value
 
-    eval _value=\${${1}}
-    case $_value in
+    eval _value=\$\{"${1}"\}
+    case "${_value}" in
         # "yes", "true", "on", or "1"
         [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1)
             return 0