Mercurial > hgrepos > DevTools > mercurial-extensions
changeset 384:97de030f8c92
Refactor: Renamed some functions and methods (hook related)
| author | Franz Glasner <fzglas.hg@dom66.de> |
|---|---|
| date | Tue, 16 Jul 2019 21:01:43 +0200 |
| parents | f9f5809eed96 |
| children | 74f893d470a5 |
| files | extensions/timestamps.py |
| diffstat | 1 files changed, 19 insertions(+), 15 deletions(-) [+] |
line wrap: on
line diff
--- a/extensions/timestamps.py Tue Jul 16 20:42:21 2019 +0200 +++ b/extensions/timestamps.py Tue Jul 16 21:01:43 2019 +0200 @@ -200,20 +200,24 @@ def uisetup(ui): - ui.setconfig(b"hooks", b"pre-update.timestamps", pre_hook) - ui.setconfig(b"hooks", b"pre-merge.timestamps", pre_hook) - ui.setconfig(b"hooks", b"pre-resolve.timestamps", pre_hook) - ui.setconfig(b"hooks", b"post-resolve.timestamps", post_hook) - ui.setconfig(b"hooks", b"pre-revert.timestamps", pre_hook) - ui.setconfig(b"hooks", b"post-revert.timestamps", post_hook) + ui.setconfig(b"hooks", b"pre-update.timestamps", generic_pre_hook) + ui.setconfig(b"hooks", b"pre-merge.timestamps", generic_pre_hook) + ui.setconfig(b"hooks", b"pre-resolve.timestamps", generic_pre_hook) + ui.setconfig(b"hooks", b"post-resolve.timestamps", generic_post_hook) + ui.setconfig(b"hooks", b"pre-revert.timestamps", generic_pre_hook) + ui.setconfig(b"hooks", b"post-revert.timestamps", generic_post_hook) -def pre_hook(ui, repo, hooktype, **kwds): - """Generic pre-xxx hook: just forwards to the corresponding repo method""" +def generic_pre_hook(ui, repo, hooktype, **kwds): + """Generic pre-xxx hook: just forwards to the corresponding repo method. + + This generic dispatcher hook simplifies configuration. + + """ repo._ts_record_pre_data(hooktype) -def post_hook(ui, repo, hooktype, **kwds): +def generic_post_hook(ui, repo, hooktype, **kwds): """Generic post-xxx hook: just forward to the `hooktype` related implementations. @@ -269,10 +273,10 @@ # # Note: We get only the target revisions. We cannot just compute the # difference - repo._ts_update(parent1=kwds.get("parent1"), - parent2=kwds.get("parent2"), - error=kwds.get("error"), - preview=kwds.get("preview", False)) + repo._ts_on_update(parent1=kwds.get("parent1"), + parent2=kwds.get("parent2"), + error=kwds.get("error"), + preview=kwds.get("preview", False)) def reposetup(ui, repo): @@ -402,7 +406,7 @@ self.__hooktype = hooktype self.__from_parents = [p.hex() for p in self[None].parents()] - def _ts_update(self, parent1=None, parent2=None, error=0, preview=False): + def _ts_on_update(self, parent1=None, parent2=None, error=0, preview=False): """Called on :hg:`hg update` and :hg:`hg merge` """ @@ -412,7 +416,7 @@ if not self.__hooktype \ or self.__hooktype not in (b"pre-update", b"pre-merge"): - self.ui.warn(_(b"timestamps: no recorded update hook data for use in `_ts_update()'\n")) + self.ui.warn(_(b"timestamps: no recorded update hook data for use in `_ts_on_update()'\n")) return if preview: self.ui.note(_(b"skipping updating timestamps in preview mode\n"))